Skip to content

Bug: Misconfiguration of arn at utils.get_standard_arn_for_region_and_resource #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
o2346 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Bug: Misconfiguration of arn at utils.get_standard_arn_for_region_and_resource #43

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
209b543
add test script
Jun 2, 2020
be56527
add test script
Jun 2, 2020
a742fed
ensure proper arn format for non-CIS stardards
Jun 2, 2020
63ea379
remove test script
Jun 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
CIS_STANDARD_RESOURCE = 'ruleset/cis-aws-foundations-benchmark/v/1.2.0'
CIS_STANDARD_ARN = 'arn:aws:securityhub:::ruleset/cis-aws-foundations-benchmark/v/1.2.0'
"arn:aws:securityhub:us-west-2::standards/pci-dss/v/3.2.1"
#"arn:aws:securityhub:us-west-2::standards/pci-dss/v/3.2.1"
def get_standard_arn_for_region_and_resource(region, standard_resource):
if standard_resource == CIS_STANDARD_ARN or standard_resource == CIS_STANDARD_RESOURCE:
return CIS_STANDARD_ARN
else:
return 'arn:{partition}:securityhub:{region}::{resource}'.format(partition='aws', region=region, resource=standard_resource)
return 'arn:{partition}:securityhub:{region}::{resource}'.format(
partition='aws',
region=region,
resource=standard_resource.split(':').pop()
)