Open
Conversation
Due to the limitations imposed by the way key bindings are registered in prompt-toolkit 1.0.15, it's necessary to grab the attributes from the centralized Keys collection by name. Until upgrading to version 2.0.0 or higher, this is the best way to register these events. TODO: Update the test names and configurations.
…le. This was added specifically for the case of upgrading, since the user might have a file without this section in their home directory. In newly-installed cases, we could include the keys in the config file by default. TODO: Update the test names and configurations.
Fixed a file close warning in 'test_utils.py'
…ompt toolkit v1.0.15 Keys collection).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding enhancement requested in issue #196
This pull request adds a section in the configuration file to allow using prompt toolkit key names to configure the key bindings. I've also updated the tests, and added a default configuration as well.
I think this likely would also address #198, as it would be configurable.