[FIX] Strip Llama special tokens from batch prompt content - #563
Open
oussamahansal wants to merge 1 commit into
Open
oussamahansal wants to merge 1 commit into
oussamahansal wants to merge 1 commit into
Conversation
|
Lexical Graph Coverage Report: The coverage is at 67.16% (target: 80%). Download the HTML report here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Meta Llama batch path renders chat messages into Llama's raw instruct template, where turn boundaries are text rather than structure. Message content was interpolated verbatim, so untrusted chunk text could close its turn and open a forged one. This strips Llama special tokens from content before formatting.
Changes
_strip_llama_special_tokens_format_llama_prompthoists system messages to the front, so a later turn can't displace the instruction block.Problem
Related issue (if any): #
Testing
pytest)Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.