issue #41: clean up localization#47
Merged
Merged
Conversation
1eea24a to
a25e97d
Compare
Collaborator
Author
|
force push: drop #34, add changelog entry |
axc450
approved these changes
Oct 26, 2023
a25e97d to
accd57e
Compare
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in #41, all localisation usage is now using "non readable" keys with sane prefixes. Since this requires reimporting all localisation data, this also removes unused strings and cleans up some obvious bogus data.
This PR can be reviewed entirely in the data added to the repository. If this data looks sane, it is required to
ns.L["new"] = ns.L['old']lines from Core/Addon.luaYou can test it by replacing Localization/enUS.lua with Localisation/rename/enUS.lua, adding
on top.