fix(encrypted_sled): bind AEAD AAD to store key - #341
Open
SashaMIT wants to merge 1 commit into
Open
Conversation
Encrypt share/value records with the sled key as associated data so ciphertext+nonce blobs cannot be moved across keys under the same password. Decrypt tries key AAD first and falls back to empty AAD for records written before this change. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Friendly bump — binds AEAD AAD to the store key for encrypted share records (legacy decrypt fallback included). Happy to iterate on the fallback window if you prefer a hard cutover. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
encrypted_sledpreviously called XChaCha20Poly1305 with empty AAD (b\"\"), so ciphertext+nonce records were not bound to their sled key / uid.Impact
Local DB / backup tamper class: under the same password, records could be swapped across keys without AEAD failure. Not claimed as remote unauth.
Test plan
encrypt_with_nonce_known_vector(goldie updated)ciphertext_bound_to_key_aadElacity CodeRED Amber review (portal #33).