Warn at startup when binding to a non-loopback address - #342
Open
SashaMIT wants to merge 1 commit into
Open
Conversation
The multisig gRPC service is plaintext and unauthenticated: any caller that can reach the port can request signatures for every key this daemon holds. The default bind is loopback, which keeps that power on the local machine, but --address 0.0.0.0 silently exposes a signing oracle to the network. Log a prominent warning at startup when the bind address is not loopback so the exposure is a deliberate operator choice rather than a configuration slip. Mirrors the client-side warning for non-loopback tofnd hosts in axelarnetwork/axelar-core#2387.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
127.0.0.1), which keeps that power on the local machine. But--address 0.0.0.0(or any non-loopback bind) silently exposes a signing oracle to the network.This mirrors the client-side warning for non-loopback
tofnd-hostvalues proposed in axelarnetwork/axelar-core#2387; together they cover both ends of the channel.Test plan
cargo checkclean;cargo clippyintroduces no new warnings.127.0.0.1bind logs nothing new;--address 0.0.0.0logs the warning at startup.Made with Cursor
Made with Cursor