fix bugs, silent failures, and simplify create-mod#29
Merged
Conversation
- config: remove dead AgentCommand source attribution code that was immediately overwritten, and unused `_ = resolved` / `defaults` var - workspace: clean up orphaned worktree if tmux window creation fails - tui: reset creating/filtering/prCreating flags on errMsg to prevent stuck dialogs - worktree: replace fmt.Sscanf (silent errors) with strconv.Atoi in parseNumstat - github: distinguish "no pull requests found" from real gh CLI errors in FetchPRReviews - tui/commands: surface DiffStats error as "diff unavailable" instead of silently showing stale "No changes"; remove redundant WindowID:"" - tui: extract resetCreateMode() helper used across all 5 create-mode exit paths - tui/view: extract renderCIBadge() helper, replace magic layout numbers with named constants Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Keep strconv.Atoi over fmt.Sscanf — properly skips malformed input rather than silencing the error with _, _. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
gh CLI exits with status 4 (resource not found) when a branch has no PR, not just status 1 with a text message. Check the exit code first, then fall back to string matching for older gh versions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes - fix bugs, silent failures, and simpl