Feature: base docker image on distroless debian13, nonroot#708
Closed
scop wants to merge 1 commit into
Closed
Conversation
Shaves off 14MB (a third) of the image size, gets rid of unnecessary distro features. There doesn't appear to be a reason to run the daemon as root in the container either, so go with the nonroot variant. https://github.com/GoogleContainerTools/distroless#why-should-i-use-distroless-images
Owner
|
Thanks @scop - however you have already submitted a PR exactly like this recently (#652) which I accepted and then had to revert.
Unfortunately there is no way for me to gauge the use of i386 in Docker (Docker does not distinguish the the number of pull requests). I can see how many binary downloads there are however for i386 (37 vs 10,300 Linux amd64 for the previous release, so a fraction). So I'm conflicted. |
Contributor
Author
|
Oops, sorry about that, just going through some deps I have that have not yet converted, forgot about having tried this one already. I guess nothing has changed since, so closing -- feel free to reopen and merge if things change. |
Owner
|
That's all good :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shaves off 14MB (a third) of the image size, gets rid of unnecessary distro features.
There doesn't appear to be a reason to run the daemon as root in the container either, so go with the nonroot variant.
https://github.com/GoogleContainerTools/distroless#why-should-i-use-distroless-images
The static-debian13 image does contain tzdata -- I'm assuming that's needed as it was explicitly installed before. (In absence of shell, image contents can be examined for example with https://github.com/wagoodman/dive)
Caveat: very lightly tested.