build: drop unused_crate_dependencies expectations - #1712
Conversation
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This PR solves #1709 build issue. |
The daily Rust update is blocked by unfulfilled lint expectations. Cargo now collects dependency usage across targets [1], avoiding false positives for dependencies used elsewhere in the same package. The unused_crate_dependencies expectations are no longer needed. Update the pinned Rust toolchains in the same commit so CI uses the new Cargo behavior. Removing the expectations with the old nightly would expose unused dependency warnings and fail Clippy. [1]: rust-lang/cargo#17298
01a0965 to
992213f
Compare
tamird
left a comment
There was a problem hiding this comment.
@tamird reviewed 59 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on swananan).
|
I'm surprised this works for both stable and nightly, but maybe I'm missing something (on mobile). |
|
Ah, got your point, that's because |
|
hmm but this is a rustc lint, right? don't we build with stable, or do we just get warnings there? I guess it's fine to tolerate warnings until this reaches stable |
|
Yes, just get warnings, so stable build only fails with |
The daily Rust update is blocked by unfulfilled lint expectations. Cargo now collects dependency usage across targets 1, avoiding false positives for dependencies used elsewhere in the same package. The unused_crate_dependencies expectations are no longer needed.
Update the pinned Rust toolchains in the same commit so CI uses the new Cargo behavior. Removing the expectations with the old nightly would expose unused dependency warnings and fail Clippy.
Added/updated tests?
We strongly encourage you to add a test for your changes.
Checklist
cargo +nightly fmt.You can find failing lints with
cargo xtask clippy.cargo test.cargo xtask public-api --bless.(Optional) What GIF best describes this PR or how it makes you feel?
This change is