Feature: Introduce Template Manage to Overleaf-Pro #6 (from CEP) #7

Musicminion · 2026-01-29T12:44:15Z

In this pr we will Introduce Template Manage to Overleaf-Pro #6 (from CEP)

filestore, add a DEL router for delete templates files
modules/template: add templates system for overleaf

Todo

Translation update. We don't want to change i18 files, so we should keep them English.
Add submit botton for new-designed Editor
Test on Cloud Environment
Add document on overleaf-pro.ayaka.space

Description

Related issues / Pull Requests

Contributor Agreement

I confirm I have signed the Contributor License Agreement

- filestore, add a DEL router for delete templates files - modules/template: add templates system for overleaf - Todo: translation update. We don't want to change i18 files, so we should keep them English.

Musicminion · 2026-01-29T12:44:49Z

Just wait before auto CI finished.

Musicminion · 2026-01-29T12:47:39Z

We have intergrated all template system files in webmodules, without any any other files. Also we add a public download router, from which we can download zip templates from overleaf pro cloud system.

Next, we need to finish some i18 chores, we want to remove no needed i18 UI, for we want to keep it simple for i18 resource translations update from upstream in the future.

Musicminion · 2026-01-30T07:20:31Z

Just fixed Manage Template display in new Editor.

Musicminion · 2026-01-30T09:17:04Z

@codex

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0bbe53fdf3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

services/web/modules/template-gallery/app/src/TemplateGalleryManager.mjs

chatgpt-codex-connector · 2026-01-30T09:21:22Z

services/web/modules/template-gallery/app/src/TemplateGalleryManager.mjs

+async function deleteTemplate({ templateId, version }) {
+  await deleteTemplateAssets(templateId, version, true)
+}


Enforce ownership/admin check before deleting templates

Deletion also accepts only templateId/version and performs the delete without any ownership/admin verification. Combined with the route’s login-only guard, any authenticated user can delete any template if they know the id. Please check that the requester is the owner or an admin before calling deleteTemplateAssets.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-01-30T09:21:22Z

services/web/modules/template-gallery/app/src/TemplateGalleryHelper.mjs

+    try {
+      userIsAdmin = (await UserGetter.promises.getUser(userId, { isAdmin: 1 })).isAdmin
+    } catch {
+      logger.error({ error, userId }, 'Logged in user does not exist, strange...')
+      userIsAdmin = false


Avoid ReferenceError in canUserOverrideTemplate catch

The catch { ... } block references error, but no binding is declared in the catch clause. In runtimes that support optional catch bindings, error will be undefined here, causing a ReferenceError and masking the original UserGetter failure. This means a missing user record will crash the override check instead of falling back to userIsAdmin = false.

Useful? React with 👍 / 👎.

Musicminion · 2026-01-30T16:15:37Z

We still have some problems:

This is due to out-of-date extracted-translations.json, we need to manully updatet this is ci.

Musicminion · 2026-01-30T16:16:28Z

Another problem: No search result should be replaced.

ayaka-lab · 2026-01-31T07:22:50Z

I will do a check for buggy display in Menu (user setting/templates), I will test this on overleaf-v6.1.0 ce.

ayaka-lab · 2026-01-31T11:36:03Z

Another problem: No search result should be replaced.

Fixed.

ayaka-lab · 2026-01-31T11:36:18Z

We still have some problems:
This is due to out-of-date `extracted-translations.json`, we need to manully updatet this is ci.

Fixed

- permission check while edit templates - catch error in try block (TemplateGalleryHelper.mjs) - some comments in router.js (templates)

Musicminion · 2026-01-31T13:50:02Z

@codex please review again.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 75417b3eb8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-01-31T13:52:17Z

services/web/modules/template-gallery/app/src/PermissionsMiddleware.mjs

+async function ensureUserCanManageTemplates(req, res, next) {
+  const user = SessionManager.getSessionUser(req.session)
+  const userId = SessionManager.getLoggedInUserId(req.session)


Import SessionManager before using it

ensureUserCanManageTemplates calls SessionManager.getSessionUser/getLoggedInUserId, but SessionManager is never imported in this module. At runtime, any request that hits this middleware will throw a ReferenceError before the permission check runs, so template management endpoints will 500 for all users. Please add the missing import (or pass the session helper in) so the middleware can execute.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-01-31T13:52:17Z

services/filestore/app/js/FileController.js

+
+  req.requestLogger.addFields({ key, bucket })
+  req.requestLogger.setMessage('deleting file')
+
+  FileHandler.deleteFile(bucket, key, function (err) {


Avoid calling non-existent FileHandler.deleteFile

FileController.deleteFile invokes FileHandler.deleteFile, but FileHandler only exports insertFile, getFile, getRedirectUrl, and getFileSize (see services/filestore/app/js/FileHandler.js). Because deleteFile is not defined, the new DELETE endpoint will throw TypeError: FileHandler.deleteFile is not a function on every request. Add a delete implementation to FileHandler or call the correct helper to prevent the endpoint from crashing.

Useful? React with 👍 / 👎.

ayaka-lab · 2026-01-31T13:59:43Z

@codex I have fixed, what about now?

chatgpt-codex-connector · 2026-01-31T13:59:48Z

To use Codex here, create a Codex account and connect to github.

Musicminion · 2026-01-31T14:00:16Z

@codex, I have fixed, what about now?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3fc26ee583

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-01-31T14:05:21Z

services/web/modules/template-gallery/app/src/PermissionsMiddleware.mjs

+  const user = SessionManager.getSessionUser(req.session)
+  const userId = SessionManager.getLoggedInUserId(req.session)
+  const isAdminOrTemplateOwner = hasAdminAccess(user) || Settings.templates?.user_id === userId
+


Honor nonAdminCanManage in template permissions

The permissions check only allows admins or the configured Settings.templates.user_id. Because Settings.templates.nonAdminCanManage (set from OVERLEAF_NON_ADMIN_CAN_PUBLISH_TEMPLATES) is never consulted here, enabling that env flag still returns 403 for non‑admin users who should be allowed to manage templates. This makes the deployment toggle ineffective and blocks intended users.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-01-31T14:05:21Z

services/web/modules/template-gallery/app/src/TemplateGalleryHelper.mjs

+    try {
+      await Template.deleteOne({ _id: templateId }).exec()
+    } catch (error) {
+      logger.error({ err, templateId }, 'Failed to delete template from MongoDB')


Avoid ReferenceError when template delete fails

In the MongoDB delete error path, the logger references err, but the caught variable is error. If the delete fails (e.g., transient DB issue), this throws a ReferenceError and masks the real failure, returning an unexpected 500 instead of the underlying error. Logging error avoids introducing a new exception.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-01-31T14:05:21Z

services/web/modules/template-gallery/frontend/js/pages/template/util/api.ts

+export function updateTemplate({
+  editedTemplate,
+  template
+}: UpdateTemplateOptions): Promise<Template | null> {


Fix updateTemplate options type mismatch

updateTemplate destructures editedTemplate, but UpdateTemplateOptions does not define that property. This produces a TypeScript error at the function signature and makes it impossible for callers to satisfy the declared type, breaking builds that run type checking.

Useful? React with 👍 / 👎.

ayaka-lab · 2026-01-31T14:08:15Z

Ok, I will stop ask for codex, Now test with cloud VM.

We will get ready for Merge this feature!

feat: Introduce Template Manage to Overleaf-Pro #6 (from CEP)

f56c799

- filestore, add a DEL router for delete templates files - modules/template: add templates system for overleaf - Todo: translation update. We don't want to change i18 files, so we should keep them English.

Musicminion self-assigned this Jan 29, 2026

fix: add menubar-manage-template for new-designed Editor

f8d10f9

Musicminion added 3 commits January 30, 2026 17:03

i18n: revert unused translation to English

047ff23

chores: remove unused import in templates

e09f50d

i18n: fix a translation error on Template module

0bbe53f

chatgpt-codex-connector bot reviewed Jan 30, 2026

View reviewed changes

fix: learn and templates in nav-bar display

57f7f33

fix: some bugs found by codex:

75417b3

- permission check while edit templates - catch error in try block (TemplateGalleryHelper.mjs) - some comments in router.js (templates)

Musicminion mentioned this pull request Jan 31, 2026

Feature: Introduce Template Manage to Overleaf-Pro #6

Closed

chatgpt-codex-connector bot reviewed Jan 31, 2026

View reviewed changes

Musicminion added 2 commits January 31, 2026 21:58

fix: import SessionManager in PermissionsMiddleware.mjs

4295f6b

fix: add deleteFile in filestore: FileHandler

3fc26ee

chatgpt-codex-connector bot reviewed Jan 31, 2026

View reviewed changes

fix: i18 in no_search_results (templates)

2f3b26a

Musicminion merged commit d57eee4 into server-pro Jan 31, 2026
1 check passed

Feature: Introduce Template Manage to Overleaf-Pro #6 (from CEP) #7

Feature: Introduce Template Manage to Overleaf-Pro #6 (from CEP) #7

Uh oh!

Conversation

Musicminion commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Todo

Description

Related issues / Pull Requests

Contributor Agreement

Uh oh!

Musicminion commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Musicminion commented Jan 29, 2026

Uh oh!

Musicminion commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Musicminion commented Jan 30, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Musicminion Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Musicminion Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Musicminion commented Jan 30, 2026

Uh oh!

Musicminion commented Jan 30, 2026

Uh oh!

ayaka-lab commented Jan 31, 2026

Uh oh!

ayaka-lab commented Jan 31, 2026

Uh oh!

ayaka-lab commented Jan 31, 2026

Uh oh!

Musicminion commented Jan 31, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

ayaka-lab commented Jan 31, 2026

Uh oh!

chatgpt-codex-connector bot commented Jan 31, 2026

Uh oh!

Musicminion commented Jan 31, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

ayaka-lab commented Jan 31, 2026 • edited by Musicminion Loading Uh oh! There was an error while loading. Please reload this page.

Musicminion commented Jan 29, 2026 •

edited

Loading

Musicminion commented Jan 29, 2026 •

edited

Loading

Musicminion commented Jan 30, 2026 •

edited

Loading

ayaka-lab commented Jan 31, 2026 •

edited by Musicminion

Loading