Conversation
Readers now wait on a channel the writer closes, instead of a weighted semaphore. The cleanup is deferred, so a panic in fn no longer leaves the key stuck; readers re-raise the panic instead. Also added Caller.MaybeKeyFromContext, rewrote the docs, and added a test for the panic path.
Coverage Report for CI Build 33868462064Coverage decreased (-1.7%) to 98.333%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps the minimum required Go version to 1.26.
Additionally, it reworks
Caller.Callaround a channel the writer closes, which drops thegolang.org/x/syncdependency and stops a panic infnfrom leaving its key stuck.Finally, the PR adds
Caller.MaybeKeyFromContext, refactors the test suite to usetesting/synctest, and brings in a release script.