fix: only ever select a Ready-named wallet in resolvePrivacyWallet - #23
Open
sainathr19 wants to merge 1 commit into
Open
fix: only ever select a Ready-named wallet in resolvePrivacyWallet#23sainathr19 wants to merge 1 commit into
sainathr19 wants to merge 1 commit into
Conversation
get-starknet-discovery finds every wallet-standard-compatible extension on the page, not just Starknet-native ones — on a profile with MetaMask's Starknet snap installed, the previous wallets[0] fallback picked it up and repeatedly called requestAccounts/supportedWalletApi against it, each call rejected with no useful signal, for as long as the page stayed open. Require a Ready-named match or return null instead of guessing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolvePrivacyWalletfell back towallets[0]when no Ready-named wallet was found.get-starknet-discoverysurfaces every wallet-standard-compatible extension, not just Starknet-native ones — on a profile with MetaMask's Starknet snap installed, that fallback picked up MetaMask and repeatedly calledrequestAccounts/supportedWalletApiagainst it, each rejected with no useful signal, on a loop, for as long as the page stayed open.null.Found while debugging the live mainnet UI: console was spamming
MetaMask - RPC Error: Unauthorized to perform actioncontinuously.Test plan
npm run buildsucceeds