feat: align creature table

[Helias]

related of azerothcore/azerothcore-wotlk#25197

Summary by CodeRabbit

• Bug Fixes
  • Updated creature identifier field references in NPC, vendor, event, quest, and spawn data queries to ensure consistent data retrieval across the application.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e3a6af2a-fab3-4013-930e-f8f3ba4fec73

📥 Commits

Reviewing files that changed from the base of the PR and between 8e247b8 and 085c10f.

📒 Files selected for processing (9)

• includes/game.php
• includes/types/item.class.php
• pages/event.php
• pages/npc.php
• pages/quest.php
• setup/tools/sqlgen/pet.ss.php
• setup/tools/sqlgen/source.ss.php
• setup/tools/sqlgen/spawns.ss.php
• setup/tools/sqlgen/taxi.ss.php

---

📝 Walkthrough

Walkthrough

All SQL queries across runtime page handlers (event.php, npc.php, quest.php), shared includes (game.php, item.class.php), and setup SQL generator scripts (spawns.ss.php, source.ss.php, pet.ss.php, taxi.ss.php) replace the creature.id1 column reference with creature.id in join conditions and select expressions. No logic, control flow, or public interfaces change.

Changes

creature.id1 → creature.id SQL Column Migration

Layer / File(s)	Summary
Runtime includes and page SQL fixes includes/game.php, includes/types/item.class.php, pages/event.php, pages/npc.php, pages/quest.php	SQL queries in Game::getWorldPosForGUID(), ItemList::getExtendedCost(), EventPage, NpcPage, and QuestPage switch join predicates and selected columns from creature.id1 to creature.id.
Setup SQL generator fixes setup/tools/sqlgen/pet.ss.php, setup/tools/sqlgen/source.ss.php, setup/tools/sqlgen/spawns.ss.php, setup/tools/sqlgen/taxi.ss.php	SQL generator scripts for pet spawns, item vendors, vehicle accessories, creature typeId, waypoints, and flightmaster entries replace creature.id1 join conditions with creature.id.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A bunny hopped through tables wide,
Found id1 lurking inside,
With one swift paw, changed every line,
Now id alone makes queries shine,
The database hops in perfect rhyme! 🐇

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch align-creature-ac

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}