Skip to content

Pull config values as floats for finer control - #10

Merged
Helias merged 1 commit into
azerothcore:masterfrom
justastranger:patch-1
Nov 2, 2025
Merged

Pull config values as floats for finer control#10
Helias merged 1 commit into
azerothcore:masterfrom
justastranger:patch-1

Conversation

@justastranger

Copy link
Copy Markdown

Changes Proposed:

  • Allow finer-grained control with floats instead of a flat integer multiplier

Tests Performed:

  • Builds without errors
  • No errors in console when using floats for config values
  • Killed creatures while changing config values

How to Test the Changes

  1. Kill a creature with module enabled and default config
  2. Change XP Rate to a float and reload configs
  3. Kill a similar creature and compare XP drops

@justastranger

Copy link
Copy Markdown
Author

Would close #9

@Helias
Helias merged commit 06d5d37 into azerothcore:master Nov 2, 2025
1 check passed
@Helias

Helias commented Nov 2, 2025

Copy link
Copy Markdown
Member

Thanks!

@justastranger
justastranger deleted the patch-1 branch November 2, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants