Skip to content

fix: worldserver errors due to deleted entries from creature table n… - #6

Merged
Helias merged 3 commits into
azerothcore:masterfrom
AldebaraanMKII:master
Jun 21, 2026
Merged

fix: worldserver errors due to deleted entries from creature table n…#6
Helias merged 3 commits into
azerothcore:masterfrom
AldebaraanMKII:master

Conversation

@AldebaraanMKII

@AldebaraanMKII AldebaraanMKII commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

…ot being deleted from game_event_creature

Summary by CodeRabbit

  • Bug Fixes
    • Resolved worldserver errors related to event creatures by applying a database correction to remove inconsistent event creature entries.

@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

A new SQL migration script is added that deletes rows from the game_event_creature table where the guid matches a hardcoded list of creature GUIDs, annotated as fixing worldserver errors.

Changes

game_event_creature Cleanup Migration

Layer / File(s) Summary
Delete stale event creature rows
data/sql/db-world/updates/quests_2026_06_21_00.sql
Adds a DELETE FROM game_event_creature WHERE guid IN (...) statement to remove a hardcoded set of creature GUIDs, resolving worldserver errors caused by their presence.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A bunny hopped through tables wide,
Found stray old GUIDs trying to hide,
With one swift DELETE, the errors were gone,
The worldserver smiled and carried on,
🐇✨ Clean rows, clear skies, hop along!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the main fix: resolving worldserver errors from deleted creature entries, which matches the core objective of removing orphaned game_event_creature entries.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@data/sql/db-world/updates/quests_2026_06_21_00.sql`:
- Line 1: The initial comment "Fix worldserver errors" at the top of the
migration file is too vague and lacks necessary context. Replace it with a
detailed comment that explains the specific worldserver errors being addressed,
how the 40 GUIDs mentioned in the migration were identified as orphaned entries,
the rationale for limiting the fix to only these GUIDs, and whether this is a
one-time corrective action or part of a broader data-integrity remediation
effort. Ensure the expanded comment provides enough context for future
maintainers to understand the problem scope and migration intent.
- Around line 2-7: The DELETE FROM `game_event_creature` statement is removing
GUIDs without verifying they are orphaned entries. Modify the WHERE clause to
add an additional condition using AND `guid` NOT IN (SELECT `guid` FROM
`creature`) to ensure only GUIDs that don't exist in the `creature` table are
deleted, preventing accidental deletion of valid creature associations.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8efae6e6-bf43-4809-8e11-994000dbdfb5

📥 Commits

Reviewing files that changed from the base of the PR and between 64cff5e and 79e9999.

📒 Files selected for processing (1)
  • data/sql/db-world/updates/quests_2026_06_21_00.sql

Comment thread data/sql/db-world/updates/quests_2026_06_21_00.sql Outdated
Comment thread data/sql/db-world/updates/quests_2026_06_21_00.sql
@Helias Helias changed the title Fixed worldserver errors due to deleted entries from creature table n… fix: worldserver errors due to deleted entries from creature table n… Jun 21, 2026
@Helias

Helias commented Jun 21, 2026

Copy link
Copy Markdown
Member

there is a startup error due to the new creature table data structure, let me fix it

@Helias

Helias commented Jun 21, 2026

Copy link
Copy Markdown
Member

I have fixed it here #7
now it should pass

@Helias
Helias merged commit 512a2dd into azerothcore:master Jun 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants