fix: worldserver errors due to deleted entries from creature table n… - #6
Conversation
…ot being deleted from game_event_creature
📝 WalkthroughWalkthroughA new SQL migration script is added that deletes rows from the Changesgame_event_creature Cleanup Migration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@data/sql/db-world/updates/quests_2026_06_21_00.sql`:
- Line 1: The initial comment "Fix worldserver errors" at the top of the
migration file is too vague and lacks necessary context. Replace it with a
detailed comment that explains the specific worldserver errors being addressed,
how the 40 GUIDs mentioned in the migration were identified as orphaned entries,
the rationale for limiting the fix to only these GUIDs, and whether this is a
one-time corrective action or part of a broader data-integrity remediation
effort. Ensure the expanded comment provides enough context for future
maintainers to understand the problem scope and migration intent.
- Around line 2-7: The DELETE FROM `game_event_creature` statement is removing
GUIDs without verifying they are orphaned entries. Modify the WHERE clause to
add an additional condition using AND `guid` NOT IN (SELECT `guid` FROM
`creature`) to ensure only GUIDs that don't exist in the `creature` table are
deleted, preventing accidental deletion of valid creature associations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8efae6e6-bf43-4809-8e11-994000dbdfb5
📒 Files selected for processing (1)
data/sql/db-world/updates/quests_2026_06_21_00.sql
|
there is a startup error due to the new |
|
I have fixed it here #7 |
…ot being deleted from game_event_creature
Summary by CodeRabbit