fix(ci): docs-lint regex matches IP addresses; dedupe Iterate heading#292
Merged
Destynova2 merged 1 commit intomainfrom Apr 26, 2026
Merged
fix(ci): docs-lint regex matches IP addresses; dedupe Iterate heading#292Destynova2 merged 1 commit intomainfrom
Destynova2 merged 1 commit intomainfrom
Conversation
Two unrelated false positives that block release-plz PRs (which touch **.md and trigger the docs-lint workflow): 1. The `no-hardcoded-version` regex `v?0\.[0-9]+\.[0-9]+` was too greedy: the `?` on `v` plus the `0\.` anchor matched the first three octets of legitimate IP addresses like `0.0.0.0` and `127.0.0.1` in network-deployment docs (oauth-setup.md, troubleshooting.md, deploy.md, security.md). Tightened to `\bv[0-9]+\.[0-9]+\.[0-9]+\b` — the literal `v` prefix is mandatory, word boundaries prevent partial matches. The exclusion list also picked up four ADRs (0012, 0015, 0016) and reference/benchmarks.md that legitimately quote historical version numbers when explaining when a feature landed. 2. `docs/how-to/auto-tune-routing.md` had two empty `## Iterate` headings in a row (MD024 no-duplicate-heading). Removed the duplicate that had no content underneath. Both were pre-existing on main — they only surfaced now because the release-plz auto-PR (#291) edits CHANGELOG.md, which the workflow's `paths: ["**.md"]` trigger picks up, running the full doc-lint suite on every release cut. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two pre-existing false positives in the docs-lint workflow that surface on every release-plz auto-PR (#291 currently blocked by both):
1.
no-hardcoded-versionregex matches IP addressesThe regex
v?0\.[0-9]+\.[0-9]+was too greedy: with?onvplus the0\.anchor, it matched the first three octets of legitimate IP addresses like0.0.0.0and127.0.0.1in network-deployment docs (oauth-setup.md,troubleshooting.md,deploy.md,security.md).Tightened to
\bv[0-9]+\.[0-9]+\.[0-9]+\b: the literalvprefix is mandatory, word boundaries prevent partial matches inside other identifiers.Also extended the exclusion list to cover ADR-0012/0015/0016 and
reference/benchmarks.mdwhich legitimately quote historical version numbers when documenting when a feature landed.2. Duplicate
## Iterateheading in auto-tune-routing.mdRemoved the duplicate empty heading that triggered
MD024 no-duplicate-heading.Why now
Both were pre-existing on
main. They surface specifically on release-plz PRs because:paths: ["**.md"]trigger picks upCHANGELOG.mdedits.The version-bump PR #291 (v0.36.39) is currently blocked. Merging this fix unblocks every future release.
Test plan
grep -REn '\bv[0-9]+\.[0-9]+\.[0-9]+\b' docs/ --include='*.md' --exclude-dir=archive | grep -vE '<exclusion>'→ empty (guard passes).docs/how-to/auto-tune-routing.mdno longer has duplicate H2.🤖 Generated with Claude Code