Add ansible-lint on PR#7
Merged
Merged
Conversation
seunghun1ee
force-pushed
the
ansible-lint
branch
12 times, most recently
from
May 2, 2025 12:25
f61691b to
e6d3ccb
Compare
seunghun1ee
marked this pull request as ready for review
May 2, 2025 13:53
m-bull
requested changes
May 6, 2025
m-bull
left a comment
m-bull
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks @seunghun1ee - couple of small nits
Contributor
|
Please could you also add a couple of lines to the repo README that explain how to run the linters? like this: Developing locallyLocally run the linters that are run in GitHub Actions using: docker run --rm \
-e RUN_LOCAL=true \
--env-file "super-linter.env" \
-v "$(pwd)":/tmp/lint \
ghcr.io/super-linter/super-linter:v7.3.0ansible-lint -c .ansible-lint.yml ansible/ |
m-bull
reviewed
May 6, 2025
seunghun1ee
force-pushed
the
ansible-lint
branch
3 times, most recently
from
May 8, 2025 11:00
e8014f1 to
7d76f6d
Compare
m-bull
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.