Skip to content

fix: restrict CRD verbs to operator-owned resources only #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mgrzybek wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: restrict CRD verbs to operator-owned resources only #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bcf28d3
fix: restrict CRD verbs to operator-owned resources only (H1)
mgrzybek Jun 22, 2026
dcc3505
fix: bump chart version to satisfy ct lint
mgrzybek Jun 22, 2026
0feaa9d
fix: add maintainers to Chart.yaml and correct ct.yaml lint config
mgrzybek Jun 22, 2026
2244bd4
fix: bump chart to 0.1.1, add maintainers, restore ct.yaml
mgrzybek Jun 22, 2026
2c8dab5
fix: regenerate helm-unittest snapshots
mgrzybek Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion charts/operator/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,11 @@ name: azimuth-caas-operator
description: Helm chart for deploying the Azimuth Cluster-as-a-Service operator.
type: application
# The version and appVersion are set by the CI script
version: 0.1.0
version: 0.1.1
appVersion: "main"
maintainers:
- name: azimuth-cloud
url: https://github.com/azimuth-cloud

dependencies:
- name: ara
Expand Down
11 changes: 9 additions & 2 deletions charts/operator/templates/clusterrole-operator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,17 @@ metadata:
name: {{ include "azimuth-caas-operator.fullname" . }}:controller
labels: {{ include "azimuth-caas-operator.labels" . | nindent 4 }}
rules:
# Required by kopf
# Required by kopf — list/watch cannot be scoped with resourceNames (collection ops)
- apiGroups: ["apiextensions.k8s.io"]
resources: ["customresourcedefinitions"]
verbs: ["*"]
verbs: ["list", "watch"]
# Write access restricted to the CRDs this operator owns
- apiGroups: ["apiextensions.k8s.io"]
resources: ["customresourcedefinitions"]
resourceNames:
- clusters.caas.azimuth.stackhpc.com
- clustertypes.caas.azimuth.stackhpc.com
verbs: ["get", "create", "update", "patch"]
- apiGroups: [""]
resources: ["namespaces"]
verbs: ["list", "watch"]
Expand Down
33 changes: 23 additions & 10 deletions charts/operator/tests/__snapshot__/snapshot_test.yaml.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ templated manifests should match snapshot:
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: azimuth-caas-operator
app.kubernetes.io/version: main
helm.sh/chart: azimuth-caas-operator-0.1.0
helm.sh/chart: azimuth-caas-operator-0.1.1
rbac.authorization.k8s.io/aggregate-to-admin: "true"
rbac.authorization.k8s.io/aggregate-to-edit: "true"
rbac.authorization.k8s.io/aggregate-to-view: "true"
Expand All @@ -142,15 +142,28 @@ templated manifests should match snapshot:
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: azimuth-caas-operator
app.kubernetes.io/version: main
helm.sh/chart: azimuth-caas-operator-0.1.0
helm.sh/chart: azimuth-caas-operator-0.1.1
name: release-name-azimuth-caas-operator:controller
rules:
- apiGroups:
- apiextensions.k8s.io
resources:
- customresourcedefinitions
verbs:
- '*'
- list
- watch
- apiGroups:
- apiextensions.k8s.io
resourceNames:
- clusters.caas.azimuth.stackhpc.com
- clustertypes.caas.azimuth.stackhpc.com
resources:
- customresourcedefinitions
verbs:
- get
- create
- update
- patch
- apiGroups:
- ""
resources:
Expand Down Expand Up @@ -234,7 +247,7 @@ templated manifests should match snapshot:
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: azimuth-caas-operator
app.kubernetes.io/version: main
helm.sh/chart: azimuth-caas-operator-0.1.0
helm.sh/chart: azimuth-caas-operator-0.1.1
name: release-name-azimuth-caas-operator:tfstate
rules:
- apiGroups:
Expand Down Expand Up @@ -263,7 +276,7 @@ templated manifests should match snapshot:
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: azimuth-caas-operator
app.kubernetes.io/version: main
helm.sh/chart: azimuth-caas-operator-0.1.0
helm.sh/chart: azimuth-caas-operator-0.1.1
rbac.authorization.k8s.io/aggregate-to-view: "true"
name: release-name-azimuth-caas-operator:view
rules:
Expand All @@ -284,7 +297,7 @@ templated manifests should match snapshot:
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: azimuth-caas-operator
app.kubernetes.io/version: main
helm.sh/chart: azimuth-caas-operator-0.1.0
helm.sh/chart: azimuth-caas-operator-0.1.1
name: release-name-azimuth-caas-operator
roleRef:
apiGroup: rbac.authorization.k8s.io
Expand All @@ -303,7 +316,7 @@ templated manifests should match snapshot:
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: azimuth-caas-operator
app.kubernetes.io/version: main
helm.sh/chart: azimuth-caas-operator-0.1.0
helm.sh/chart: azimuth-caas-operator-0.1.1
name: release-name-azimuth-caas-operator
spec:
replicas: 1
Expand Down Expand Up @@ -369,7 +382,7 @@ templated manifests should match snapshot:
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: azimuth-caas-operator
app.kubernetes.io/version: main
helm.sh/chart: azimuth-caas-operator-0.1.0
helm.sh/chart: azimuth-caas-operator-0.1.1
name: release-name-azimuth-caas-operator-extravars
stringData:
extravars: |
Expand All @@ -383,7 +396,7 @@ templated manifests should match snapshot:
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: azimuth-caas-operator
app.kubernetes.io/version: main
helm.sh/chart: azimuth-caas-operator-0.1.0
helm.sh/chart: azimuth-caas-operator-0.1.1
name: release-name-azimuth-caas-operator
spec:
ports:
Expand All @@ -404,5 +417,5 @@ templated manifests should match snapshot:
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: azimuth-caas-operator
app.kubernetes.io/version: main
helm.sh/chart: azimuth-caas-operator-0.1.0
helm.sh/chart: azimuth-caas-operator-0.1.1
name: release-name-azimuth-caas-operator