Skip to content

Host Zenith service icons in repo#640

Merged
wtripp180901 merged 4 commits into
mainfrom
feat/host-icons
Jul 15, 2026
Merged

Host Zenith service icons in repo#640
wtripp180901 merged 4 commits into
mainfrom
feat/host-icons

Conversation

@wtripp180901

Copy link
Copy Markdown
Contributor

Allows for follow up PR replacing links to icons for Zenith services

headlamp_icon_url: AnyHttpUrl = "https://raw.githubusercontent.com/kubernetes-sigs/headlamp/v0.43.0/docs/images/icon.png"
with links to assets in our own repo

@wtripp180901
wtripp180901 requested a review from a team as a code owner July 8, 2026 12:14
@amanning9

Copy link
Copy Markdown
Contributor

Not sure if we might need to put a note saying that these are not Apache licenced/ are trademarks of their owners? Not sure how other projects do this, might need a quick look around.

irt-shpc
irt-shpc previously approved these changes Jul 13, 2026
@irt-shpc
irt-shpc self-requested a review July 13, 2026 16:21
@irt-shpc

Copy link
Copy Markdown
Contributor

Not sure if we might need to put a note saying that these are not Apache licenced/ are trademarks of their owners? Not sure how other projects do this, might need a quick look around.

The overall Github repo has an Apache license in the root and I can't find anything saying the icons or docs aren't covered. There's no TM in the icons either but I'm no lawyer?

@amanning9

Copy link
Copy Markdown
Contributor

I think the source of truth for these logos is here: https://github.com/cncf/artwork

The 'licence' / usage guidance is here: https://github.com/cncf/artwork/blob/main/LICENSE.md

I would:

  • Remove LICENCE.md from this folder.
  • Alter ATTRIBUTION.md to:
    • Remove the part about apache
    • Say that the logos came from the avover repository and that licence info can be found there (itemise each logo)

@amanning9 amanning9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

@wtripp180901
wtripp180901 merged commit 9de8093 into main Jul 15, 2026
7 checks passed
@amanning9
amanning9 deleted the feat/host-icons branch July 15, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants