argocd-azimuth>client.yaml: Refactor the service name to match subchart#107
Open
irt-shpc wants to merge 1 commit into
Open
argocd-azimuth>client.yaml: Refactor the service name to match subchart#107irt-shpc wants to merge 1 commit into
irt-shpc wants to merge 1 commit into
Conversation
If the azimuth Argo CD is named with "argocd" in the name the zenith client never connects to the Kube service due to a name mismatch. The subchart's default `values.yaml` sets `nameOverride: argocd` and the argo-helm argo-cd chart that we subchart uses a template to define the service name used for the main argo-cd web UI: https://github.com/argoproj/argo-helm/blob/4676fa5171dbc07d1ac7da7a4996561a6f2804dd/charts/argo-cd/templates/_helpers.tpl#L111 This calls out to the chart's template for `argo-cd.fullname` which has some logic to prevent duplication in the name. Add similar logic to our Client template so the names match and the zenith clent can connect. PLAT-1245
irt-shpc
force-pushed
the
PLAT-1245-argo-naming
branch
from
July 2, 2026 12:23
e293c5d to
c7c81fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the azimuth Argo CD is named with "argocd" in the name the zenith client never connects to the Kube service due to a name mismatch. The subchart's default
values.yamlsetsnameOverride: argocdand the argo-helm argo-cd chart that we subchart uses a template to define the service name used for the main argo-cd web UI:https://github.com/argoproj/argo-helm/blob/4676fa5171dbc07d1ac7da7a4996561a6f2804dd/charts/argo-cd/templates/_helpers.tpl#L111 This calls out to the chart's template for
argo-cd.fullnamewhich has some logic to prevent duplication in the name.Add similar logic to our Client template so the names match and the zenith clent can connect.
PLAT-1245