Conversation
amanning9
reviewed
Jul 1, 2026
amanning9
requested changes
Jul 15, 2026
Contributor
There was a problem hiding this comment.
While we're here, I think it's worth using a cache mount instead of rm -rf /var/lib/apt/lists/*?
eg:
RUN --mount=type=cache,target=/var/cache/apt,sharing=locked
--mount=type=cache,target=/var/lib/apt,sharing=locked
apt update && apt-get --no-install-recommends --no-install-suggests install -y gcc
- and also remove the line which delete's the apt-cache.
This means there different build stages will share the apt-cache.
Docs: https://docs.docker.com/build/cache/optimize/#use-cache-mounts
Signed-off-by: Mathieu Grzybek <mathieu@stackhpc.com>
`wget` needs `ca-certificates`.
Co-authored-by: Alex Manning <alexm@stackhpc.com>
Co-authored-by: Alex Manning <alexm@stackhpc.com>
Co-authored-by: Alex Manning <alexm@stackhpc.com>
Co-authored-by: Alex Manning <alexm@stackhpc.com>
Co-authored-by: Alex Manning <alexm@stackhpc.com>
Co-authored-by: Alex Manning <alexm@stackhpc.com>
Contributor
Author
|
I applied all your suggested changes. That makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.