test: raise internal/ coverage from 77.5% to 93.0% (+53 tests)#306
Merged
Conversation
Add targeted unit tests for previously untested or partially-covered branches: PurgeResources orchestration (new purge_test.go), Reconcile error paths via interceptor.Funcs, otherFinalizer, password auth scope resolution, malformed JSON/PEM handling, and pagination edge cases. Document the corresponding use cases as new/extended Gherkin scenarios in ROADMAP.md and update test counts in README.md. Signed-off-by: Mathieu Grzybek <mathieu@stackhpc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/controllerandinternal/openstack, raising statement coverage from 77.5% to 93.0% (115 → 168 tests total).PurgeResourcesorchestration tests (newpurge_test.go),Reconcileerror-path tests viainterceptor.Funcs,otherFinalizer, password-auth scope resolution, malformed JSON/PEM handling, and pagination edge cases.ROADMAP.md(US1.2, US1.4, US1.5, US2.2/US2.3, US5.3, US7.1/US7.2, US8.5, US12.3/US12.4) and update test counts inREADME.md.Test plan
go test ./...— 168 tests passgo vet ./...— cleangofmt -l— no diffsgo tool cover -func(77.5% → 93.0%)