Skip to content

Plat 1282 helm v4#41

Open
irt-shpc wants to merge 8 commits into
mainfrom
PLAT-1282-helm-v4
Open

Plat 1282 helm v4#41
irt-shpc wants to merge 8 commits into
mainfrom
PLAT-1282-helm-v4

Conversation

@irt-shpc

Copy link
Copy Markdown

No description provided.

Comment thread .github/workflows/pypi-publish.yaml Outdated
irt-shpc added 2 commits July 17, 2026 11:06
Update pyproject.toml to use uv for project and package management.
Add isort and black as linting tools.
@irt-shpc
irt-shpc force-pushed the PLAT-1282-helm-v4 branch from 1c34049 to 720565e Compare July 17, 2026 10:07
@irt-shpc
irt-shpc requested a review from wtripp180901 July 17, 2026 10:49
wtripp180901
wtripp180901 previously approved these changes Jul 17, 2026

@wtripp180901 wtripp180901 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread pyproject.toml Outdated
Comment thread pyhelm3/client.py
Comment thread pyproject.toml Outdated
[tool.poetry]
[project]
name = "pyhelm3"
version = "0.4.0"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to replace the dynamic versioning which used to be provided by setuptools-scm, else we will always produce version 0.4.0 regardless of tag?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we just update the version manually when we want to issue a release. I don't know how we manage releases of python packages or if it's consistent? I'd rather do what everything else in spirit even if with different tooling. Git blame says they version has only ever been 0.4.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixed with hath now, right?

Comment thread pyhelm3/command.py Outdated
Comment thread pyhelm3/client.py

@amanning9 amanning9 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good part of me things we need to get some before and after tests for this whole change lest there be a world of pain.

Maybe this is a good candidate for some claude-generated tests, generated BEFORE this change and then we can run them after the change.

Comment thread pyhelm3/command.py
irt-shpc added 6 commits July 17, 2026 14:50
…guments

Helm v4 has changes some command line arguments:
- `--all` has been dropped as an argument to `helm list`, the default behaviour
  is now to show all releases.
- `--atomic` was renamed to `--rollback-on-failure` for `helm install` and `helm
  upgrade`

See https://helm.sh/docs/changelog/ for details.
The client will issue warnings if incompatible arguments are used with a helm
client but should use the correct flags.
@irt-shpc
irt-shpc force-pushed the PLAT-1282-helm-v4 branch from bd233a5 to 37e333f Compare July 17, 2026 13:54

@amanning9 amanning9 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants