fix: Round 8 slop audit — 14 security findings#32
Merged
Conversation
2 CRITICAL: triple-quote Python injection (F-1, V-CD-001), fireHook command injection (F-2, V-GR-001) 1 CRITICAL (new): codegen GovernanceHardError bypass (V-CG-001) 3 HIGH: SQLite NULL deref + unchecked ops (F-3), agent unchecked dict access (F-4/F-5), Python importlib bypass (F-6, V-PY-001) 4 MEDIUM: agent msg/handle guards (V-AG-001..004), range dict .at() guard (V-RT-006), VM polyglot .at() guard (V-VM-001), package_manager metacharacter blocklist (V-PKG-002) 4 LOW: STUB detector cleanup (V-LN-001) F-7 (vm.cpp ~82 unchecked .asInt()/.asString()) deferred — requires opcode-level classification of compiler type guarantees. Verified: build 0 errors, 396/396 tests, 738/738 leak checks, 100/100 fuzz cases. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
NAAb Governance Report
All governance checks passed! Generated by NAAb Governance Engine v4.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
call_dispatch.cppF-1) — replacedexec('''...''')withPy_CompileString()+PyEval_EvalCode().fireHook()command injection (governance_reports.cppF-2) — addedshellEscape()for all variable substitutions.codegen_impl.cppmissingGovernanceHardErrorcatch-and-rethrow — HARD blocks were silently swallowed bycatch(std::exception&).block_search_index.cpp(F-3). Agent unchecked dict access inagent_impl.cpp(F-4/F-5). Pythonimportlib.import_module()bypass inpython_c_executor.cpp(F-6)..at()guard, VM polyglot.at()guard, package_manager metacharacter blocklist extension.llm_patterns.cpp..asInt()/.asString()) — requires opcode-level classification of compiler type guarantees.R4→R5→R6→R7→R8 trend: 12→6→3→6→14 (R8 was exhaustive full-codebase sweep with pre-audit deep dive).
Test plan
run-all-tests.sh: 396/396 accounted, 0 real failures (3 cold-start flakes pass on re-run)test_error_msg_leaks.sh: 738/738 passedtest_govern_json_fuzz.sh: 100/100, 0 crashes🤖 Generated with Claude Code