fix: telemetry path leak + REPL hardcoded block count#34
Merged
Conversation
G-1 (CRITICAL): Telemetry events in governance_reports.cpp included raw absolute paths (e.g., /data/data/com.termux/files/home/...) in ev["file"] fields. These flowed unsanitized through telemetry_forwarder to external webhooks, leaking host directory structure. Fixed by applying ErrorSanitizer::sanitizeFilePaths() at both emission sites (line 249 emitRefusalAttestation, line 887 writeTelemetry loop). G-2 (LOW): REPL printed hardcoded "24,167 blocks available" — a static number with no runtime basis. Removed. Findings from Gemini 30-level slop audit, verified against actual code. 15 of 20 claims were false positives or by-design. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
NAAb Governance Report
All governance checks passed! Generated by NAAb Governance Engine v4.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes from Gemini 30-level slop audit triage. Of ~20 findings, 15 were false positives or by-design. 2 real issues fixed here:
governance_reports.cppincluded raw absolute paths (ev["file"] = current_check_file_) forwarded unsanitized to external webhooks viatelemetry_forwarder.cpp. AppliedErrorSanitizer::sanitizeFilePaths()at both emission sites (refusal attestation + check results loop)."24,167 blocks available"— a static number with no runtime basis. Removed.Notable false positives from the audit
Test plan
🤖 Generated with Claude Code