[CLEANUP] Improve code readability for AvailablePermissionSets#25
Open
moritz-ngo wants to merge 1 commit into
Open
[CLEANUP] Improve code readability for AvailablePermissionSets#25moritz-ngo wants to merge 1 commit into
moritz-ngo wants to merge 1 commit into
Conversation
Member
|
I assume this only happens in TYPO3 v14? |
Author
|
I'm running TYPO3 v13.4.22 |
Contributor
|
can confirm the bug. I would prefer to drop second constructor argument |
Contributor
|
Hi @moritz-ngo , would you apply my suggestion, so we would merge your PR |
This commit fixes the following error: ``` (1/1) TypeError B13\PermissionSets\AvailablePermissionSets::backendGroupSelector(): Argument b13#2 ($parentObject) must be of type TYPO3\CMS\Backend\Form\FormDataProvider\TcaSelectItems, TYPO3\CMS\Core\DataHandling\ItemProcessingService given ``` Resolves b13#24
Author
|
I just saw, that the unnecessary I just fixed a typo in the class' PhpDoc and made the code a bit easier to read, feel free to accept or close this PR – I'm fine with both :) |
moritz-ngo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the following error:
Resolves #24