Four modules capture getPlannotatorDataDir() at import time and derive their paths from that value, so they use whatever the environment variable was set to when the module first loaded. Every other consumer resolves it per call.
packages/shared/improvement-hooks.ts: DATA_DIR, plus HOOKS_BASE_DIR and LEGACY_BASE_DIRpackages/server/codex-review.ts: DATA_DIR, DEBUG_LOG_PATH, SCHEMA_DIR, SCHEMA_FILEpackages/server/tour/tour-review.ts: TOUR_SCHEMA_DIR, TOUR_SCHEMA_FILEpackages/server/guide/guide-review.ts: GUIDE_SCHEMA_DIR, GUIDE_SCHEMA_FILE
These constants are module-private, so no signatures change. vendor.sh copies improvement-hooks.ts into the Pi extension. Nothing outside tests sets PLANNOTATOR_DATA_DIR after startup, so production behavior is unchanged.
Motivation
storage.ts captured the value the same way until #1437. There it broke annotate's submission-record tests on Linux runners, and the initial diagnosis attributed the failure to path normalization in an unrelated feature.
embedded.ts loads @plannotator/server with await import(...). That call ran during a test that had set PLANNOTATOR_DATA_DIR to its own temp directory, so storage.ts captured that directory and used it for the remainder of the process.
packages/server/index.ts imports improvement-hooks.ts, so the same dynamic import loads it under the same conditions. The other three modules are imported by review.ts, which that dynamic import does not reach. 38 test files set the variable at runtime, and Bun's test-file order is filesystem-dependent, so the captured value varies as test files are added.
Approach
Replacing DATA_DIR alone is insufficient. DEBUG_LOG_PATH, SCHEMA_FILE, TOUR_SCHEMA_FILE, and GUIDE_SCHEMA_FILE are derived at module scope and stay fixed.
A regression test must import the module before setting the environment variable, because the reverse order passes with or without the fix. packages/shared/storage.test.ts is the model. improvement-hooks.test.ts currently spawns a subprocess with a modified HOME for the same reason, and can set the variable in-process after this change.
Four modules capture
getPlannotatorDataDir()at import time and derive their paths from that value, so they use whatever the environment variable was set to when the module first loaded. Every other consumer resolves it per call.packages/shared/improvement-hooks.ts:DATA_DIR, plusHOOKS_BASE_DIRandLEGACY_BASE_DIRpackages/server/codex-review.ts:DATA_DIR,DEBUG_LOG_PATH,SCHEMA_DIR,SCHEMA_FILEpackages/server/tour/tour-review.ts:TOUR_SCHEMA_DIR,TOUR_SCHEMA_FILEpackages/server/guide/guide-review.ts:GUIDE_SCHEMA_DIR,GUIDE_SCHEMA_FILEThese constants are module-private, so no signatures change.
vendor.shcopiesimprovement-hooks.tsinto the Pi extension. Nothing outside tests setsPLANNOTATOR_DATA_DIRafter startup, so production behavior is unchanged.Motivation
storage.tscaptured the value the same way until #1437. There it broke annotate's submission-record tests on Linux runners, and the initial diagnosis attributed the failure to path normalization in an unrelated feature.embedded.tsloads@plannotator/serverwithawait import(...). That call ran during a test that had setPLANNOTATOR_DATA_DIRto its own temp directory, sostorage.tscaptured that directory and used it for the remainder of the process.packages/server/index.tsimportsimprovement-hooks.ts, so the same dynamic import loads it under the same conditions. The other three modules are imported byreview.ts, which that dynamic import does not reach. 38 test files set the variable at runtime, and Bun's test-file order is filesystem-dependent, so the captured value varies as test files are added.Approach
Replacing
DATA_DIRalone is insufficient.DEBUG_LOG_PATH,SCHEMA_FILE,TOUR_SCHEMA_FILE, andGUIDE_SCHEMA_FILEare derived at module scope and stay fixed.A regression test must import the module before setting the environment variable, because the reverse order passes with or without the fix.
packages/shared/storage.test.tsis the model.improvement-hooks.test.tscurrently spawns a subprocess with a modifiedHOMEfor the same reason, and can set the variable in-process after this change.