Conversation
extractFrontmatter hoisted indented child keys to the root, clobbering same-named keys and rendering wrong values. Parse nested maps and arrays of maps; flat frontmatter renders byte-identically. Closes backnotprop#1485.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extractFrontmattertrimmed every line, so indented child keys (generated:/by:/at:,verified:/sources:arrays of maps) hoisted to the document root, where same-named keys clobbered each other and the card rendered wrong-but-complete-looking values.The parser is now indentation-aware: nested maps stay grouped, arrays of maps group per item, and flat scalars, string arrays, block scalars (
|/>), and CRLF all behave as before.FrontmatterCardrenders nested structures recursively (flat frontmatter renders exactly as today).Testing:
bun test packages/ui/utils/parser.test.ts(197 pass, incl. 6 new nested-structure tests + regressions), fullbun run typecheckclean.Closes #1485.