Conversation
Gutter + now honors the live multi-line selection (single-line fallback preserved); N/P jump between changed hunks on both diff views. Closes backnotprop#991, closes backnotprop#1543.
AllFilesCodeView is bundled into the portable guide viewer; the hunk-navigation change alters the bundle hash.
FNDEVVE
force-pushed
the
fix/991-diff-selection-1543-hunk-nav
branch
from
September 16, 2026 11:23
18bbaeb to
afb36a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two reviewer-ergonomics fixes in the code review diff views:
Full-range gutter annotations (#991). The gutter
+forwarded Pierre's single clicked line even when the reviewer had a multi-line browser selection. Both diff views now snapshot the liveSelectionon capture-phase pointerdown (reusing thediffSelectionhelpers) and the gutter handler forwards the snapshot range when it spans real lines, falling back to the clicked line otherwise. The all-files view additionally checks the snapshot came from the clicked file.Next/prev changed-hunk jump (#1543, keyboard only). New
N/Pbindings (verified free across the composed review registry) jump between changed hunks on both the single-file and all-files views, resolving targets from Pierre's parsedhunksand scrolling via the existing shadow-DOM line query. Pure index resolution lives inutils/hunkNavigation.tswith unit tests; the gutter-minimap idea from the thread is deliberately out of scope.Also registers the new
diffSelection.test.tsin the CI DOM-test allowlist, as required by the allowlist guard.Testing:
DOM_TESTS=1 bun testover the two util suites plus theDiffViewer/AllFilesCodeViewselection harnesses (35 pass incl. the allowlist), fullbun run typecheckclean. Thereview-editortsconfig (not a CI gate) shows zero new diagnostics vs base.Closes #991, closes #1543.