Conversation
Hand-rolled shells regress the backnotprop#1546 caption overlap (abs-pos canvas escaping a static viewport's overflow). Add a copy-instead-of-invent reference with a five-rule clipping contract, wire it into the visual-explainer path and delivery gate, and pin the contract with tests. Refs backnotprop#1546.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hand-rolled diagram shells in visual-explainer deliverables can regress the caption-overlap defect from #1546 (absolutely-positioned canvas escaping a static viewport's
overflow, painting the zoomed diagram over the figure caption). The skill had no canonical shell — each artifact reinvented viewport, canvas, and caption markup.This adds
references/diagram-shell.md: a copy-instead-of-invent skeleton (HTML + CSS + zoom/pan behavior notes) with a five-rule clipping contract, wired into the visual-explainer path's "Before generating" list and the delivery gate (zoom-to-max + pan-to-extremes self-check in both palettes). The contract is pinned by tests: the viewport rule must keepposition: relative+overflow: hidden, the canvas must stay absolute, and the SKILL.md pointer must survive edits.The #1546 instance itself lives in the reporter's artifact file (fixed there with the one-line viewport positioning); this PR is the systemic half so future shells can't regress it.
Testing:
bun test apps/skills/extra/plannotator-visual-explainer/SKILL.test.ts(10 pass, incl. 4 new contract tests).Refs #1546.