Skip to content

fix(court): show near-side mascot backs and mirror racket hand by facing #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haritabh17 merged 1 commit into from
Jul 5, 2026
Merged

fix(court): show near-side mascot backs and mirror racket hand by facing #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions components/BadmintonCourt.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,6 +664,7 @@ export default function BadmintonCourt() {
color={customizations[id].color}
size={customizations[id].size}
isLeftHanded={customizations[id].isLeftHanded}
facingAway
icon={customizations[id].icon}
iconType={customizations[id].iconType}
look={effectiveLooks[id]}
Expand Down
11 changes: 9 additions & 2 deletions components/PlayerMarker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@ interface PlayerMarkerProps {
position: { x: number; y: number };
color: string;
size?: number;
/** Full-body mascot looks mirror for left-handed players. */
/** Mascot looks mirror so the racket sits on the handedness' screen side. */
isLeftHanded?: boolean;
/** Near-court players (team 2) face away from the viewer; mascots show their back. */
facingAway?: boolean;
icon?: string;
iconType?: 'icon' | 'text' | 'photo';
/** Selected look; mascot looks render the full-body figure. */
Expand All @@ -41,6 +43,7 @@ export function PlayerMarker({
color,
size,
isLeftHanded = false,
facingAway = false,
icon = 'account',
iconType = 'icon',
look = 'classic',
Expand Down Expand Up @@ -186,7 +189,11 @@ export function PlayerMarker({
band={color}
label={label}
width={markerSize}
flipped={isLeftHanded}
// Raw art holds the racket on the screen's right. Facing the viewer,
// a right hand reads on the screen's left, so front views mirror for
// right-handers; back views mirror for left-handers.
flipped={facingAway ? isLeftHanded : !isLeftHanded}
facingAway={facingAway}
/>
</Animated.View>
)}
Expand Down
Loading
Loading