fix(links): drop debug keystore fingerprint from assetlinks source copy - #25
Merged
Merged
Conversation
The debug keystore is committed to this public repo, so serving its fingerprint let anyone's rebuild pass App Links verification. Live site (badmlabs.github.io#2) now serves only the Play signing and upload certs; this syncs the source copy and updates the stale docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to badmlabs/badmlabs.github.io#2 (already merged and live).
The debug keystore is committed to this public repo, so serving its fingerprint in
assetlinks.jsonlet anyone's rebuild pass App Links verification for badmlabs.github.io. The live site now serves only the Play App Signing and upload certs.This PR syncs the
links-site/source copy with what's deployed and updates the stale docs:links-site/.well-known/assetlinks.json— debug fingerprint removed, Play signing + upload certs keptlinks-site/README.md— documents why the debug cert is excluded and how to force-verify App Links locally (adb shell pm set-app-links ... 2 all)android/app/build.gradle— comment on the debug-keystore release fallback no longer claims assetlinks verifies it