feat(court): render mascots as full figures in the 3D world view - #29
Merged
Merged
Conversation
The 3D view drew placeholder pins for every player; mascot looks now render as the same 2D figure art, billboarded into the projection: - far-court figures face the camera, near-court figures show their backs with handedness mirroring — the flat court's orientation rules, which cover every angle the +/-18-degree yaw camera can reach - perspective-scaled with a ground contact shadow; feet plant on the shadow at full tilt and the figure recenters at b=0 so the 2D<->3D morph stays seamless - scene split into layers around the net so far figures stand behind it and near figures in front; each mascot keeps its own Svg root (per-mascot gradient ids collide inside a shared root) - non-mascot looks keep the existing pins; shuttle untouched - CUF 06 now dresses both singles players in mascots first, with a slow yaw sweep on the standing figures for the PR video
The shuttle layer drew over everything, so it slid across a near player's body on approach. Near figures now sandwich the shuttle by court depth each frame: a shuttle between the player and the net is beyond him from the camera and his body occludes it; once it passes behind him it draws over him. Sprites also depth-sort within a side.
Collaborator
Author
|
Pushed a depth fix from review: the shuttle no longer slides across a near mascot's body on approach — near figures sandwich the shuttle by per-frame court depth, so the body occludes it at the hit and it draws over him only after passing behind. Re-verified with a frame burst during 3D playback (chip visibly clipped by Koala's body at contact) and a full green Maestro run of flow 06. |
maestro inputText over gRPC intermittently hits DEADLINE_EXCEEDED on CI emulators (flow 03 flaked with a green local run and a green previous CI run). A real regression still fails twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 3D world view drew generic pins for every player while the flat court showed full mascot art — mascots now carry into 3D as the same figures, billboarded into the projection:
mFaceetc.) differ per animal and would collide inside one shared rootCUF coverage
Flow
06-tilt-3d-drillnow dresses both singles players in mascots (Fox far / Koala near) before tilting to 3D, and adds a slow yaw sweep on the standing figures — so the PR's recorded video showcases front and back views, net occlusion, and mid-rally movement.Test plan