Feature/implement slf4j#5
Closed
purianmol wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
@bakayu can you review my pr |
Owner
|
too many lines of code changed, you committed a lot of unnecessary code, put up a new PR with necessary changes only. |
bakayu
reviewed
Aug 12, 2025
| <version>${junit.jupiter.version}</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> |
Owner
There was a problem hiding this comment.
Could you add a comment with links linking back to the maven repository site. For reference:
Suggested change
| <dependency> | |
| <!-- JUnit for testing --> | |
| <!-- https://mvnrepository.com/artifact/org.junit.jupiter/junit-jupiter-api --> | |
| <dependency> |
|
|
||
| @OnOpen | ||
| public void onOpen(Session session) { | ||
| logger.info("Connected to battlegrid server!"); |
Owner
There was a problem hiding this comment.
Duplicate logger call here. Please remove this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4