Merged
Conversation
tanut32039
force-pushed
the
add-flow-chain
branch
from
51493e8 to
9730b06
Compare
RogerKSI
force-pushed
the
add-soroban-chain
branch
from
96c6c09 to
9364067
Compare
RogerKSI
force-pushed
the
add-soroban-chain
branch
from
9364067 to
5a4cddd
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Soroban (Stellar smart contracts) chain support, including Ed25519 signing, Soroban transaction construction/simulation, and a new gRPC endpoint to request Soroban signatures.
Changes:
- Introduces Ed25519 signing support in the local signer and signature abstraction.
- Adds Soroban codec to build/simulate/sign Soroban transactions and returns a signed envelope.
- Extends config + CLI mnemonic derivation to support a Soroban-friendly SLIP-0010 derivation scheme, and updates the proto API with
SignSoroban.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/signer/signature/ed25519.rs | Adds Signature trait support for ed25519-dalek signatures. |
| src/signer/signature.rs | Exposes the new ed25519 signature module. |
| src/signer/local.rs | Adds Ed25519 key handling + signing path for Soroban and address generation via StrKey. |
| src/server/service.rs | Implements sign_soroban gRPC method and wires Soroban into address listing. |
| src/config/signer/local.rs | Adds Soroban chain type and an optional derivation_scheme (BIP32 vs SLIP-0010). |
| src/commands/utils.rs | Adds SLIP-0010 Ed25519 derivation and modifies mnemonic-based key derivation selection. |
| src/codec/soroban.rs | New Soroban transaction builder, simulator (RPC), tx-hash computation, and envelope encoding + tests. |
| src/codec.rs | Exposes the new Soroban codec module. |
| proto/fkms/v1/signer.proto | Adds Soroban RPC/messages and new chain enum value. |
| Cargo.toml | Adds Soroban/Ed25519/Stellar + HTTP client dependencies. |
| Cargo.lock | Updates lockfile for new dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added 2 commits
April 3, 2026 14:18
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added 2 commits
April 7, 2026 11:33
Marca23
approved these changes
Apr 8, 2026
tanut32039
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.