Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for Secret Network (“Secret” chain type) including address derivation and an FKMS gRPC endpoint to produce signed Secret/Cosmos SDK transactions containing encrypted CosmWasm execute messages.
Changes:
- Extend signer abstractions and local signer to support
ChainType::Secret, including Secret bech32 address derivation. - Add Secret-specific codec utilities for encrypting execute messages and building/signing Cosmos SDK tx bytes.
- Add
SignSecretgRPC method + protobuf messages and wire it into the server.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
src/config/signer/local.rs |
Adds Secret to supported local chain types. |
src/signer.rs |
Adds Secret address derivation and exposes optional private_key() on the Signer trait. |
src/signer/local.rs |
Implements Secret key handling/address derivation; stores and returns private key bytes. |
src/codec/cosmwasm_secret.rs |
New module to encrypt Secret execute messages and sign Cosmos SDK transactions. |
src/codec.rs |
Exposes the new cosmwasm_secret codec module. |
src/server/service.rs |
Adds sign_secret RPC implementation and chain type mapping. |
proto/fkms/v1/signer.proto |
Adds SignSecret RPC, payload/response types, and SECRET enum value. |
Cargo.toml / Cargo.lock |
Adds dependencies required for Cosmos/Secret tx signing + encryption. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RogerKSI
reviewed
Apr 9, 2026
tanut32039
reviewed
Apr 16, 2026
tanut32039
reviewed
Apr 16, 2026
tanut32039
reviewed
Apr 16, 2026
tanut32039
reviewed
Apr 16, 2026
tanut32039
reviewed
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.