Skip to content

[Feat] add secret chain#22

Open
Marca23 wants to merge 12 commits intomainfrom
add-secret-chain
Open

[Feat] add secret chain#22
Marca23 wants to merge 12 commits intomainfrom
add-secret-chain

Conversation

@Marca23
Copy link
Copy Markdown
Contributor

@Marca23 Marca23 commented Apr 8, 2026

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for Secret Network (“Secret” chain type) including address derivation and an FKMS gRPC endpoint to produce signed Secret/Cosmos SDK transactions containing encrypted CosmWasm execute messages.

Changes:

  • Extend signer abstractions and local signer to support ChainType::Secret, including Secret bech32 address derivation.
  • Add Secret-specific codec utilities for encrypting execute messages and building/signing Cosmos SDK tx bytes.
  • Add SignSecret gRPC method + protobuf messages and wire it into the server.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
src/config/signer/local.rs Adds Secret to supported local chain types.
src/signer.rs Adds Secret address derivation and exposes optional private_key() on the Signer trait.
src/signer/local.rs Implements Secret key handling/address derivation; stores and returns private key bytes.
src/codec/cosmwasm_secret.rs New module to encrypt Secret execute messages and sign Cosmos SDK transactions.
src/codec.rs Exposes the new cosmwasm_secret codec module.
src/server/service.rs Adds sign_secret RPC implementation and chain type mapping.
proto/fkms/v1/signer.proto Adds SignSecret RPC, payload/response types, and SECRET enum value.
Cargo.toml / Cargo.lock Adds dependencies required for Cosmos/Secret tx signing + encryption.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/signer/local.rs
Comment thread src/signer.rs Outdated
Comment thread src/server/service.rs Outdated
Comment thread src/codec/cosmwasm_secret.rs
Comment thread src/codec/cosmwasm_secret.rs
Comment thread src/codec/cosmwasm_secret.rs Outdated
Comment thread src/signer/local.rs
Comment thread Cargo.toml Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/signer.rs Outdated
Comment thread src/signer/local.rs
Comment thread src/server/service.rs Outdated
Comment thread src/codec/cosmwasm_secret.rs Outdated
Comment thread src/codec/cosmwasm_secret.rs Outdated
Comment thread src/signer/local.rs
Comment thread .github/workflows/ci.yml
Comment thread src/server/service.rs Outdated
Comment thread src/server/service.rs Outdated
Comment thread proto/fkms/v1/signer.proto Outdated
Comment thread src/codec/cosmwasm_secret.rs
@Marca23 Marca23 requested review from RogerKSI and tanut32039 April 16, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants