Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the request verification flow to support verifying against multiple BandChain verify nodes (URLs) instead of a single endpoint, and updates configuration/tests accordingly.
Changes:
- Replace single
verify_urlconfiguration withverify_urls/VERIFY_REQUEST_URLSlist-based configuration. - Update
VerifyRequestMiddlewareto verify against multiple URLs concurrently and select an acceptable response. - Expand middleware test coverage for multi-URL scenarios and adjust CI/dependency setup.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
app/middleware/verify_request.py |
Implements multi-URL verification (concurrent requests, result selection, updated error behavior). |
app/settings.py |
Renames/changes verification setting to VERIFY_REQUEST_URLS: list[HttpUrl]. |
app/main.py |
Wires new verify_urls setting into the middleware. |
tests/test_verify_middleware.py |
Updates existing tests and adds multi-URL verification test cases. |
pyproject.toml |
Updates packaging version and modifies build-system requirements. |
.github/workflows/ci.yaml |
Updates setup-python action and installs updated packaging tooling before Poetry install. |
.env.example |
Updates example env var to VERIFY_REQUEST_URLS JSON-list format. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… v2 compatibility - Add test_verify_request_with_multiple_urls_both_success_one_parse_fail to verify behavior when both nodes return HTTP 200 but one fails to parse - Fix VerifyReport model to work with Pydantic v2 by adding defaults to Optional fields - Update test expectation to match new error message for parse failures - Add timeout to _verify_url HTTP request
Marca23
previously approved these changes
Feb 19, 2026
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RogerKSI
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.