Skip to content

Fixed the DtoGenerator to support multi projects#282

Merged
baoduy merged 1 commit intomainfrom
dev
Mar 27, 2026
Merged

Fixed the DtoGenerator to support multi projects#282
baoduy merged 1 commit intomainfrom
dev

Conversation

@baoduy
Copy link
Copy Markdown
Owner

@baoduy baoduy commented Mar 27, 2026

This pull request introduces a few project configuration changes to improve testability and packaging for the EfCore.DtoGenerator project. The most significant updates involve making the GenerateDtoAttribute internal, exposing internals for testing, and refining project references for test projects.

Testability improvements:

  • Added InternalsVisibleTo in DKNet.EfCore.DtoGenerator.csproj to allow the EfCore.DtoGenerator.Tests project to access internal members, facilitating more thorough unit testing.
  • Changed GenerateDtoAttribute from public to internal, restricting its visibility to within the assembly and friend assemblies.

Test project reference configuration:

  • Updated the test project reference in EfCore.DtoGenerator.Tests.csproj to include PrivateAssets and IncludeAssets, ensuring proper analyzer and asset handling during test builds.

Packaging adjustments:

  • Enabled packaging of the analyzer DLL and attribute source file in the NuGet package by uncommenting relevant <None Include=... Pack="true" ... /> entries in DKNet.EfCore.DtoGenerator.csproj.

IDE/test session state:

  • Minor changes to the .DotSettings.user file, updating the active state of test sessions (no impact on code or build).

@baoduy baoduy merged commit 4a6d9c5 into main Mar 27, 2026
8 of 9 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.61%. Comparing base (c9416b4) to head (d5b7459).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #282   +/-   ##
=======================================
  Coverage   84.61%   84.61%           
=======================================
  Files         159      159           
  Lines        3653     3653           
  Branches      568      568           
=======================================
  Hits         3091     3091           
  Misses        405      405           
  Partials      157      157           
Flag Coverage Δ
unittests 84.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

📊 Code Coverage Report

| Metric | Coverage |
|--------|----------|
| **Line Coverage** | 87.8% |
| **Branch Coverage** | 82.2% |
| **Method Coverage** | 86% |

**Lines:** 3208/undefined covered
**Branches:** 1220/undefined covered

📈 [View Full Coverage Report](https://github.com/baoduy/DKNet/actions/runs/23624919159)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant