Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
==========================================
- Coverage 84.40% 84.37% -0.04%
==========================================
Files 159 159
Lines 3656 3655 -1
Branches 567 564 -3
==========================================
- Hits 3086 3084 -2
- Misses 412 413 +1
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
📊 Code Coverage Report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request refactors the data seeding configuration system in the
DKNet.EfCore.Extensionslibrary to modernize and simplify how seed data is provided and applied. The main changes involve removing the synchronous, model-managed seeding interface (HasData), shifting to an asynchronous data seeding approach, and updating related APIs and implementations accordingly.Core changes to data seeding:
HasDataproperty and related logic from theIDataSeedingConfigurationinterface and its implementations, eliminating support for synchronous, model-managed seed data registration. [1] [2]DataSeedingConfiguration<TEntity>fromGetData()(synchronous) toGetDataAsync()(asynchronous), and updated theSeedAsyncimplementation to use this method for seeding data asynchronously and avoiding duplicates. [1] [2]Related updates and cleanup:
RegisterDataSeedingextension and its usage from the model customization pipeline, as model-managed seeding viaHasDatais no longer supported. [1] [2]GetDataAsyncmethod instead of the removedGetData.