Repository navigation
feat(waf): run phase 5 on blocked transactions (barbacane-waf 0.1.1) - #161
Merged
Merged
Conversation
Bump the engine to barbacane-waf 0.1.1, which runs phase 5 (logging and correlation) after a disruptive verdict (parapet#10). A blocked transaction is now logged and correlated the same as one that passed, so CRS 980xxx correlation rules contribute to the audit record. - The response path already runs phase 5 through inspect_response; it now takes effect after a response-phase block. - A request-phase block calls WafInspection::run_logging() before the audit record is written, so the request-block path is correlated too. - inspect_response doc and the phase-ordering test updated: a phase-3 block still skips phase 4 but now runs phase 5. Closes #158.
|
Warning Review limit reachedNext included review available in 26 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes #158 by wiring the parapet#10 engine change into the audit log.
What
barbacane-waf 0.1.1 (parapet#10) runs phase 5 (logging and correlation) after a disruptive verdict, matching ModSecurity. A blocked transaction is now logged and correlated the same as one that passed, so CRS 980xxx correlation rules contribute to the audit record on blocks.
Changes
barbacane-waf0.1.0 → 0.1.1.process_loggingininspect_response; with 0.1.1 it now takes effect after a response-phase block.WafInspection::run_logging()before the audit record is written, so request-phase blocks are correlated too (the request path returns before response inspection, so it needs the explicit call).inspect_responsedoc and the phase-ordering unit test updated: a phase-3 block still skips phase 4 but now runs phase 5.Tests
a_phase_three_block_skips_phase_four_but_runs_phase_five(flipped from the old engine behaviour).