Fix destructive collection permissions for shared users#3
Draft
cursor[bot] wants to merge 2 commits intomainfrom
Draft
Fix destructive collection permissions for shared users#3cursor[bot] wants to merge 2 commits intomainfrom
cursor[bot] wants to merge 2 commits intomainfrom
Conversation
Co-authored-by: Vitalii Melnychuk <vitaliimelnychuk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
canRenameOrDeleteCollectionto allow destructive operations only forownerandcreatoraccess statessrc/server/access/collections.test.tsto ensure grants/non-members cannot perform destructive actionsBug and impact
Grant recipients (users shared onto a collection but not owners/creators) were treated as eligible for rename/delete. Those operations can move or remove all objects under a collection prefix, causing major user-facing breakage and potential data loss.
Root cause
canRenameOrDeleteCollectionreturnedstate.kind !== "none", which accidentally granted destructive privileges tograntstate.Fix and validation
state.kind === "owner" || state.kind === "creator"npm test✅ (4 files, 20 tests passing)