Switch viewer close to SharedFlow command bus #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Kick.close()as the programmatic entry point for requesting viewer close.Description
ViewerCommandsinmain-runtimethat exposes acloseRequests: SharedFlow<Unit>andrequestClose()to emit close commands.KickImpl.close()emit a close request viaViewerCommands.requestClose()and kept theKickpublic API and companion helperKick.close()intact.CloseManagerimplementations and holder utilities and wired UI layers to collectViewerCommands.closeRequests: AndroidKickActivitynow lifecycle-collects and callsfinish(), JVMLaunchManagerusesLaunchedEffecttowindow.dispose(), iOSIosSceneControllercollects in aMainScopejob and callsdismiss(), and WasmLaunchManagercollects and removes thekick-viewerDOM element.CONTROL_PANEL_CLOSE_BUTTON_ID) and to callKick.close()and show an alert when the button is clicked.Testing
Codex Task