Skip to content

fix(spend-permission): use wallet-signed data for returned permission #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
faisalnugroho wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(spend-permission): use wallet-signed data for returned permission #332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...unt-sdk/src/interface/public-utilities/spend-permission/methods/requestSpendPermission.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ const requestSpendPermissionFn = async (
// Check if we should use wallet_sign (when capabilities are provided) or eth_signTypedData_v4
let signature: string;
let permissionHash: string;
let signedMessage = typedData.message;

if (capabilities) {
// Use wallet_sign with capabilities
Expand Down Expand Up @@ -122,8 +123,9 @@ const requestSpendPermissionFn = async (
};

signature = signResult.signature;
signedMessage = signResult.signedData.message;
permissionHash = await getHash({
permission: signResult.signedData.message,
permission: signedMessage,
chainId,
});
} else {
Expand All @@ -142,7 +144,7 @@ const requestSpendPermissionFn = async (
permissionHash,
signature,
chainId,
permission: typedData.message,
permission: signedMessage,
};

return permission;
Expand Down