Skip to content

fix: propagate pending user operation RPC errors #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
realmehmetali wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: propagate pending user operation RPC errors #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions packages/account-sdk/src/interface/payment/getPaymentStatus.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,40 @@ describe('getPaymentStatus', () => {
});
});

it('should propagate RPC errors from the pending user operation lookup', async () => {
vi.mocked(fetch)
.mockResolvedValueOnce({
json: async () => ({ jsonrpc: '2.0', id: 1, result: null }),
} as Response)
.mockResolvedValueOnce({
json: async () => ({
jsonrpc: '2.0',
id: 2,
error: {
code: -32602,
message: 'Invalid user operation hash',
},
}),
} as Response);

await expect(
getPaymentStatus({
id: '0xinvalid',
testnet: false,
})
).rejects.toThrow('RPC error: Invalid user operation hash');

const { logPaymentStatusCheckCompleted, logPaymentStatusCheckError } = await import(
':core/telemetry/events/payment.js'
);
expect(logPaymentStatusCheckCompleted).not.toHaveBeenCalled();
expect(logPaymentStatusCheckError).toHaveBeenCalledWith({
testnet: false,
correlationId: 'mock-correlation-id',
errorMessage: 'RPC error: Invalid user operation hash',
});
});

it('should handle RPC errors gracefully', async () => {
vi.mocked(fetch).mockResolvedValueOnce({
json: async () => ({
Expand Down
5 changes: 5 additions & 0 deletions packages/account-sdk/src/interface/payment/getPaymentStatus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,11 @@ export async function getPaymentStatus(options: PaymentStatusOptions): Promise<P
}),
}).then((res) => res.json());

if (userOpResponse.error) {
const errorMessage = userOpResponse.error.message || 'Network error';
throw new Error(`RPC error: ${errorMessage}`);
}

if (userOpResponse.result) {
// UserOp exists but no receipt yet - it's pending
if (telemetry) {
Expand Down