Skip to content

Conversation

@cody-wang-cb
Copy link
Contributor

@cody-wang-cb cody-wang-cb commented Apr 23, 2025

Adding instruction to https://github.com/base/node-reth under the reth folder, also a README for more info.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Apr 23, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link
Collaborator

@danyalprout danyalprout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of duplicating the existing Reth setup can we parameterize the binary in the existing image? (or use a shared base image).

Parameterizing the binary (with the default being the current version) feels like the way to go IMO. It'll make the images bigger due to having a second binary, but that's a temporary state -- we'll want to make our Reth build the default one.

@cb-heimdall cb-heimdall dismissed danyalprout’s stale review April 24, 2025 17:36

Approved review 2791311177 from danyalprout is now dismissed due to new commit. Re-request for approval.

@cody-wang-cb cody-wang-cb merged commit d6794bb into main Apr 24, 2025
7 checks passed
@cody-wang-cb cody-wang-cb deleted the cody/add-base-reth-node branch April 24, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants