Skip to content

Conversation

@wbnns
Copy link
Contributor

@wbnns wbnns commented Apr 24, 2025

This PR refactors and updates to the latest configs for Geth and Reth

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Apr 24, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@wbnns wbnns marked this pull request as ready for review April 24, 2025 13:06
tobidae-cb
tobidae-cb previously approved these changes Apr 24, 2025
@cb-heimdall cb-heimdall dismissed tobidae-cb’s stale review April 24, 2025 16:09

Approved review 2791185488 from tobidae-cb is now dismissed due to new commit. Re-request for approval.

Copy link
Contributor

@meyer9 meyer9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove a deprecated env

@cb-heimdall
Copy link
Collaborator

Review Error for meyer9 @ 2025-04-28 18:56:41 UTC
User failed mfa authentication, see go/mfa-help

@wbnns wbnns force-pushed the wbnns/update-client-configs branch from e4fb291 to c5b10b8 Compare April 28, 2025 19:35
@wbnns wbnns requested a review from meyer9 April 28, 2025 20:24
@wbnns wbnns merged commit de4d3d4 into main Apr 28, 2025
9 checks passed
@wbnns wbnns deleted the wbnns/update-client-configs branch April 28, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants