fix: update Axios lockfile for security advisories - #237
Conversation
|
Claude finished @natansil's task —— View job Code Review — PR #237 (Axios lockfile security update)
Verdict: LGTM ✅ — This is a clean, minimal, and correct security remediation. What the change doesThe only modification is in "node_modules/axios": {
- "version": "1.17.0",
- "resolved": ".../axios-1.17.0.tgz",
- "integrity": "sha512-J8SwNxprqqpbfene...",
+ "version": "1.18.1",
+ "resolved": ".../axios-1.18.1.tgz",
+ "integrity": "sha512-3nTvFlvpn9Zu/Rk...",Correctness ✅
Security ✅
Scope ✅
Suggestions / follow-ups (non-blocking)
No bugs, no performance concerns, and no test coverage changes needed for a lockfile-only bump. Nice, focused PR. |
🚀 Package Preview Available!Install this PR's preview build with npm: npm i @base44-preview/sdk@0.8.39-pr.237.30e00b4Prefer not to change any import paths? Install using npm alias so your code still imports npm i "@base44/sdk@npm:@base44-preview/sdk@0.8.39-pr.237.30e00b4"Or add it to your {
"dependencies": {
"@base44/sdk": "npm:@base44-preview/sdk@0.8.39-pr.237.30e00b4"
}
}
Preview published to npm registry — try new features instantly! |
|
Claude finished @natansil's task —— View job Code Review — PR #237 (Axios security update)
Verdict: LGTM ✅ — Clean, minimal, correct security remediation. Changes
Total: +5/-5 across the two files. This aligns exactly with the PR description. Correctness ✅
Security ✅
Scope ✅
Follow-ups (non-blocking)
No bugs, no performance concerns, and no test coverage changes needed for a dependency bump. Nicely focused PR. View job • Branch: |
Summary
^1.17.0to^1.18.1so published SDK consumers cannot resolve a vulnerable Axios release1.17.0to1.18.1Context
The production dependency audit currently fails on both:
mainrun: https://github.com/base44/javascript-sdk/actions/runs/29828398144npm audit --omit=dev --audit-level=highreports multiple high-severity advisories against the directly installedaxios@1.17.0. Axios1.18.0contains the fixes, but it is not available from the npm registry;1.18.1is the smallest available patched release.Dependency change
axios(direct production dependency)^1.17.0^1.18.11.17.01.18.1Updating the declared lower bound is necessary because consumers of the published SDK do not use this repository's lockfile.
Validation
npm ci— passed in the Security Audit, Unit Tests, and Lint workflowsnpm audit --omit=dev --audit-level=high— passed;found 0 vulnerabilitiesnpm run test:unit— passednpm run lint— passednpm run build(tsc) — passed in the preview workflowgit diff --check— passedChecks: https://github.com/base44/javascript-sdk/pull/237/checks
Remaining audit findings
The report-only full
npm auditstill reports 2 high-severity dev-only findings:brace-expansion(GHSA-3jxr-9vmj-r5cp)js-yaml(GHSA-52cp-r559-cp3m)They do not affect
npm audit --omit=devand are intentionally outside this focused production Axios remediation.