UI/compare filter - #60
Merged
Merged
Conversation
- HTML bugs: colspan 11→12 in index-themes.html; fix </div>→</section>
+ missing grid-area closing tag in index-v2-dock.html
- stopBtn2 (#stopBtn2 in tabs layout) wired to stopBenchmark in app.js
and synced in applyButtonState so enabled/disabled state is correct
- Add missing A1/A2/A3 HTML shells (static/index-a1.html, a2, a3) and
fix variants/index.html links from /index-aX.html → /static/index-aX.html
- CSS: replace deprecated word-break:break-word with overflow-wrap in
v1-instrument, v2-dock, v2-monitor, v3-startup, v3-tabs, sql-grid
- CSS: add clip-path:inset(50%) alongside clip:rect() in .sr-only rules
(v1-instrument, v3-startup)
- a3.css: add ::marker{display:none} for Firefox alongside ::-webkit-details-marker
- a2.css: replace hardcoded rgba(255,255,255) values with CSS token vars
- v4-terminal.css: raise --text-dim/#text-muted to WCAG AA contrast;
add html[data-design="v2…v6"] channel palette overrides
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ntrast, a11y labels - v4-overlay.html/app.js: label[role="button"] now responds to Enter/Space - v4-overlay.css: mobile .grid-viewport inset restored (0 0 60px 0 instead of auto bottom) - c1-clean-lab.css: raise --text-dim #9CA3AF → #767676 for WCAG AA 4.5:1 on white - index-a2.html: add aria-label to single-letter layout nav links Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Dead code — never linked from production, no nav switcher, no routes. Deleted 7 files (index-a1/a2/a3.html, index-themes.html, variants/a1/a2/a3.css), removed A2 tab-switching from app.js, cleaned up variants/index.html. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Each V1-V4 layout now has a second standalone CSS theme (Instrument/Monitor/ Startup/Terminal) loaded disabled by default. A "Theme" button in the nav switches between them; choice persists via localStorage. Both font families preloaded in the Google Fonts URL. - V1 Grid Hero ↔ Instrument (Fira Code / Fira Sans) - V2 Dock ↔ Monitor (IBM Plex Sans / JetBrains Mono) - V3 Tabs ↔ Startup (Space Grotesk / DM Sans) - V4 Overlay ↔ Terminal (Share Tech Mono / Fira Code) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…t toggle The v1-instrument/v2-monitor/v3-startup/v4-terminal CSS files target the classic sidebar layout, not the V-layout HTML structures. Removed broken per-V-layout toggle. Added a <select> theme switcher on index.html instead — switches between style.css and 4 alternatives; choice persists via localStorage. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sql-grid.css: full D5 Arctic Light override block (sticky headers, hover states, compare-head, result chips, pass/fail cells on white bg). Per-channel tinted hover + compare-head rows for D1-D4 and D6. channels-d456.css: fix sql-compare-bar visibility on D5 light theme. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
app.js: - v2-dock: bind settings slideout toggle/open/close via data-dock-action attributes (replaces inline onclick, fixes CSP violation) - v3-tabs: sync aria-selected on label[role="tab"] with radio :checked state for screen reader tab announcements - label[role="button|tab"]: extend keyboard handler to cover v3 tab labels - theme toggle: apply persisted theme on first load unconditionally so label/classes always match stylesheet state index-v2-dock.html: rebuilt dock with slideout settings panel, SVG icons, model chip list, dock__btn pattern index-v3-tabs.html: tab labels gain role="tab" + aria-controls; setup tab restructured into card grid (Endpoints / Models / Settings) index-v4-overlay.html: minor fixes variants/index.html: note copy update Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…hover/polish Universal filter in compare bar, anchored over Model/Run column. Search-icon SVG, visibility counter, MutationObserver guarded against microtask loop. Per-channel CSS polish in channels-d456.css and sql-grid.css with focus rings, accent borders, v5 readable border, v6 monospace amber. Hover ring in V-layouts: transform:scale was clipped by overflow:auto on .grid-area__sql/.sql-compare-area; replaced with inset box-shadow + filter:brightness. Plus: add #sqlCompareContainer to index-v3-tabs.html, remove inline onclick on v4-overlay compareRunsBtn, align variants/index.html note with shared switcher, add index-compare-filter.html as parallel classic entry URL.
# Conflicts: # static/app.js # static/index-v1-gridhero.html # static/index-v3-tabs.html # static/variants/c3-warm-instrument.css # static/variants/channels-d456.css # static/variants/sql-grid.css # static/variants/v1-gridhero.css # static/variants/v1-instrument.css # static/variants/v2-dock.css # static/variants/v2-monitor.css # static/variants/v3-startup.css # static/variants/v3-tabs.css # static/variants/v4-terminal.css
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
Changesgitignore Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of change
Verification
python -m pytestRisk
Codex review notes
Summary by CodeRabbit
.graymatter/content is no longer tracked.