Harden recovery verification and submission runbook - #36
Merged
Conversation
batbrainy
marked this pull request as ready for review
July 31, 2026 20:00
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35
Problem
Post-merge review found that the recovery verifier could recreate the worker in live mode,
suppressed fixture one-shot failures, and printed persistence counts without asserting them.
The reviewer runbook also mixed live and fixture state, overstated replay guarantees, and no
longer matched the intended two-page design brief.
Scope
There are no schema, public API, endpoint, or Compose topology changes.
Validation
docker compose run --rm --build test: 1,734 examples, 0 failuresbash -n script/verify_recovery.shdocker compose config --quietFollow-up gate
After CI passes and this PR merges, the complete submission checklist will be rerun from a
fresh clone of the resulting default-branch SHA. The submission email remains blocked until
that run is completely green.