Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important things to know about multiple DNS in VpnService:
1.
Priority: The order matters. The first IP added is the highest priority. If it fails to respond, the system resolver will move to the next one in the list.
2.
IPv4 and IPv6: You can mix them. You can add multiple IPv4 addresses and multiple IPv6 addresses.
3.
Limits: While there isn't a strict documented limit in the Android API, most systems handle up to 3 or 4 DNS servers reliably. Your current FALLBACK_DNS_SERVERS list has 4 entries, plus your primary one, which is a safe and standard configuration.
4.
Routing: When you add a DNS server via the builder, Android automatically ensures that traffic destined for those DNS IP addresses is routed through the VPN interface, even if you haven't explicitly added a route for them.